Added a feature to avoid linebreaks between option when displaying help #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lp AdditionalNewLineAfterOption
ericnewton76
requested changes
May 11, 2018
ericnewton76
requested changes
May 11, 2018
| @@ -183,20 +183,20 @@ public void Dispose() | |||
| settings.EnableDashDash)(arguments, optionSpecs); | |||
| } | |||
|
|
|||
| private static ParserResult<T> MakeParserResult<T>(ParserResult<T> parserResult, ParserSettings settings) | |||
| private /*static*/ ParserResult<T> MakeParserResult<T>(ParserResult<T> parserResult, ParserSettings settings) | |||
There was a problem hiding this comment.
It would be better to just remove the static modifier altogether. We can see the change in diffs.
| { | ||
| return DisplayHelp( | ||
| parserResult, | ||
| settings.HelpWriter, | ||
| settings.MaximumDisplayWidth); | ||
| } | ||
|
|
||
| private static ParserResult<T> DisplayHelp<T>(ParserResult<T> parserResult, TextWriter helpWriter, int maxDisplayWidth) | ||
| private /*static*/ ParserResult<T> DisplayHelp<T>(ParserResult<T> parserResult, TextWriter helpWriter, int maxDisplayWidth) |
There was a problem hiding this comment.
It would be better to just remove the static modifier altogether. We can see the change in diffs.
| @@ -315,7 +315,7 @@ public void Invoke_AutoBuild_for_Options_returns_appropriate_formatted_text() | |||
| }); | |||
|
|
|||
| // Exercize system | |||
| var helpText = HelpText.AutoBuild(fakeResult); | |||
| var helpText = HelpText.AutoBuild(fakeResult, new ParserSettings()); | |||
There was a problem hiding this comment.
All of these test updates should've alerted you to the fact that you broke the existing expected interface. This will cause problems for people simply upgrading from a patch release, we'd have to make it wait until a full version release.
As noted elsewhere, you should preserve this method and make your new method an overload with the old method calling the new method with that default ParserSettings instance.
moh-hassan
force-pushed
the
develop
branch
2 times, most recently
from
b211712 to
746885a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Linked with issue #224.
I try to make this to allow users to set option in ParserSettings to have or not linebreaks between option when displaying help.
Thanks for advance